Re: [PATCH 1/4] arm64: dts: qcom: hamoa: Add CoreSight nodes for APSS debug block

[Konrad Dybcio]

On 9/22/26 12:35 PM, Jie Gan wrote:
> The APSS debug block is built with CoreSight devices like ETM,
> replicator, funnel and TMC ETF. Add dt nodes for these devices to enable
> ETM trace.
> 
> The replicator, funnel and TMC ETF nodes in this block are physically
> powered by the CPU cluster power rail rather than by a dedicated always-on
> rail. Add a power-domains property referencing the corresponding
> cluster_pdN domain to each of these nodes, so their power state is
> tied to the CPU cluster domain and the runtime PM core can power the
> domain on before the devices are accessed and let it be powered off
> otherwise.
> 
> Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
> ---

[...]

> +		funnel@12080000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x0 0x12080000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";
> +
> +			in-ports {

No need for power-domains here? (also same question for the other
platforms)

Konrad