[PATCH 9/9] HID: playstation: Drop redundant report ID validation in ps_get_report

From: Dmitry Torokhov

Date: Mon Oct 12 2026 - 23:44:40 EST


Now that the core HID request handling validates returned report IDs
for report retrieval requests centrally, the report ID check in the
PlayStation driver is redundant. Drop it.

Assisted-by: LLM
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
---
drivers/hid/hid-playstation.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index f9dc9378cf77..de51a22ecf0c 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -813,11 +813,6 @@ static int ps_get_report(struct hid_device *hdev, u8 report_id, u8 *buf,
return -EINVAL;
}

- if (buf[0] != report_id) {
- hid_err(hdev, "Invalid reportID received, expected %d got %d\n", report_id, buf[0]);
- return -EINVAL;
- }
-
if (hdev->bus == BUS_BLUETOOTH && check_crc) {
/* Last 4 bytes contains crc32. */
u8 crc_offset = size - 4;

--
2.56.0.385.gd3acb90ef8-goog