Re: [PATCH v2 1/3] s390/pci: Adjust alignment in insn trace

[Matthew Rosato]

On 10/12/26 10:21 AM, Gerd Bayer wrote:
> Currently we have 64bit wide fields start at odd byte-offsets in the
> insn traces for pci_error in the s390dbf debug area, which are hard to
> decode in hex dumps. At the same time, trace entries are padded at the
> end.
> 
> Drop the packed attribute on the struct definition to exploit the
> compiler's natural alignment, introduce explicit padding before and
> after the 64bit fields for humans, and add a static assertion to avoid
> accidential overruns of 2 lines in the s390dbf trace.

nit: typo 'accidental'

> 
> Signed-off-by: Gerd Bayer <gbayer@xxxxxxxxxxxxx>
> Reviewed-by: Benjamin Block <bblock@xxxxxxxxxxxxx>

AFAICT no impact to the amount of space used in s390dbf either since we
were already claiming 2 16B entries -- but the result is far more readable.

Reviewed-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>