Re: [RFC PATCH v2 0/7] Add ethernet support for the Amlogic T7
From: Lucas Tanure
Date: Fri Oct 09 2026 - 16:53:32 EST
On Fri, Oct 9, 2026 at 1:13 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Fri, Oct 09, 2026 at 06:59:49AM +0100, Lucas Tanure wrote:
> > On Wed, Oct 7, 2026 at 2:01 PM Andrew Lunn <andrew@xxxxxxx> wrote:
> > >
> > > On Wed, Oct 07, 2026 at 09:26:20AM +0100, Lucas Tanure wrote:
> > > > The T7 pairs a Synopsys gigabit MAC with the same glue registers the
> > > > G12A has, but nothing described it. This adds the binding, the driver
> > > > support and the device tree nodes, and enables the port on the Khadas
> > > > VIM4.
> > > >
> > > > Unlike the G12A, the controller reaches DRAM through a pipeline stage
> > > > with a gate of its own, sys_ampipe_eth. Nothing else claims it, so
> > > > clk_disable_unused switches it off and transfers stop.
> > > >
> > > > v2 changes the RGMII delays, after review. phy-mode describes the
> > > > board, not which chip adds the delay, so this board is rgmii-id.
> > > > dwmac-meson8b did the opposite, and ignored the *-internal-delay-ps
> > > > properties. Patch 1 fixes that. The VIM4 needs it because the RTL8211F
> > > > transmit delay does not work here.
> > >
> > > What is special about the RTL8211F?
> > Maybe nothing, it may be this board. I cannot tell from here.
>
> Yes, look at my other reply. The RTL8211F is very likely correct. It
> is the MAC drivers handling of delays which is broken. You get to fix
> it for this new device.
>
> Andrew
Doing exactly that. v3 leaves the existing delay code alone and adds a
path used only by the T7 compatible, built on Maxime's
phy_fix_phy_mode_for_mac_delays(). Testing it now, then I will send
it.
Thanks,
Lucas