Re: [PATCH] landlock: Move the domain layer counter out of the anonymous union

From: Nathan Chancellor

Date: Fri Oct 09 2026 - 16:47:12 EST


On Fri, Oct 09, 2026 at 10:23:14AM -0700, Nick Desaulniers wrote:
> On Thu, Oct 8, 2026 at 4:49 AM Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx> wrote:
> >
> > On 26-10-07 14:49:28, Nick Desaulniers wrote:
> > > Would you consider this a bug in clang, or an error in how the
> > > __counted_by attribute is applied?
> > >
> > It turns out Amaan Qureshi has already reported exactly this Landlock
> > issue and proposed an LLVM fix:
> >
> > https://github.com/llvm/llvm-project/pull/228309
>
> In that case, I would _not_ work around the compiler bug like this and
> instead wait for that fix to land in clang, then bump the required
> version of clang for counted-by.
>
> Kees and Nathan are traveling for LPC, so I don't expect quick
> feedback from them, but they should confirm whether they agree with my
> proposal.

Bill/Kees/Justin should review that patch upstream but bumping the
required version for __counted_by to clang-24 (or maybe 23.1.x if it can
land in release/23.x) kind of sucks :/ but if this is a big enough
footgun that we don't want to continuously workaround, I guess we have
no choice.

--
Cheers,
Nathan