Re: [PATCH net 2/2] bnxt_en: Pad short SW USO segments to BNXT_MIN_PKT_SIZE
From: Michael Chan
Date: Fri Oct 09 2026 - 16:30:07 EST
On Fri, Oct 9, 2026 at 1:23 PM Joe Damato <joe@xxxxxxx> wrote:
> OK, I'll submit a v2 with the following comment. Let me know if this OK
> with you before I respin:
>
> /* bnxt_features_check() makes the stack segment these, but paths
> * that skip validate_xmit_skb() (e.g. generic XDP_TX of a GRO'd
> * skb) can still get here. Padding every segment would need more
> * BDs than bds_needed reserves below, so drop instead.
> */
> if (unlikely(bnxt_sw_gso_pad_len(hdr_len, mss)))
> goto drop;
>
> Also, since I haven't seen this issue in production myself and according
> to my math it is not possible to hit this with QUIC on ipv4, Jakub asked
> me to submit this to net-next instead of net.
Sounds good. For both patches:
Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature