Re: [PATCH 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard binding

[Krzysztof Kozlowski]

On 09/10/2026 14:20, wyibo6109@xxxxxxxxx wrote:

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23


> +  touchpad-xy-max:
> +    description: Touchpad maximum X and Y coordinates in units.
> +    items:
> +      - description: maximum X
> +      - description: maximum Y
> +    minItems: 2
> +    maxItems: 2

None of this was tested. Anyway, use existing properties from
touchscreen schema for example or actually better explain why this is
not deducible from the compatible.

> +
> +  touchpad-xy-resolution:
> +    description: Touchpad X and Y resolution in units per millimetre.
> +    items:
> +      - description: X resolution
> +      - description: Y resolution
> +    minItems: 2
> +    maxItems: 2
> +
> +required:
> +  - compatible
> +  - power-gpios
> +  - tx-enable-gpios
> +  - wake-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    serial {
> +        #address-cells = <1>;
> +        #size-cells = <0>;

Drop node

> +
> +        keyboard {
> +            compatible = "oneplus,pogo-keyboard";
> +            power-gpios = <&pmic_gpios 12 GPIO_ACTIVE_HIGH>;
> +            tx-enable-gpios = <&pmic2_gpios 6 GPIO_ACTIVE_HIGH>;
> +            wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>;
> +            touchpad-xy-max = <2560 1440>;
> +            touchpad-xy-resolution = <24 25>;
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8014b9f82..e978a26c1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20149,6 +20149,13 @@ S:	Maintained
>  T:	git git://linuxtv.org/media.git
>  F:	drivers/media/i2c/ov9734.c
>  
> +ONEPLUS POGO-PIN KEYBOARD DRIVER
> +M:	Yibo Wang <wyibo6109@xxxxxxxxx>
> +L:	linux-input@xxxxxxxxxxxxxxx
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> +F:	drivers/input/keyboard/oneplus-pogo-kbd.c

There is no such file.

> +
>  ONBOARD USB HUB DRIVER
>  M:	Matthias Kaehlcke <mka@xxxxxxxxxxxx>
>  L:	linux-usb@xxxxxxxxxxxxxxx


Best regards,
Krzysztof