Re: [PATCH] USB: sierra: Fix urb leak in sierra_submit_delayed_urbs()

[Johan Hovold]

On Thu, Sep 17, 2026 at 11:00:54AM +0200, Johan Hovold wrote:
> On Wed, Sep 16, 2026 at 04:53:52PM +0000, Wentao Liang wrote:
> > sierra_submit_delayed_urbs() takes a reference to each delayed urb
> > with usb_get_from_anchor() before submitting it. The submit failure
> > path releases the reference with usb_free_urb(), but on the success
> > path the reference is never dropped: the urb is only anchored in the
> > active list and the USB core unanchors it on completion, leaving the
> > reference returned by usb_get_from_anchor() dangling so the urb
> > object is never freed.
> > 
> > Drop the reference with usb_put_urb() after a successful submission,
> > matching the reference handling in sierra_write() and the sierra_close()
> > drain loop. Skip the rest of the loop body with continue on the error
> > path, which already frees the urb.
> > 
> > Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> 
> This looks correct, but as Greg already asked you elsewhere, did you
> forget to add an Assisted-by tag here as well? How was this issue found
> and fixed?
> 
> Also, you need to start replying to feedback. According to the list
> archives you have haven't replied to any of the four mails commenting on
> your patches that I've sent you so far.

You still haven't replied to anything I've ever sent you so I'm gonna
start treating you like a bot.

I've fixed up the USB serial and cdc-acm leaks you reported and given
you credit for reporting them.

Johan