Re: [PATCH net-next] net: stmmac: move XPCS lifetime management to platform drivers

From: patchwork-bot+netdevbpf

Date: Thu Oct 08 2026 - 22:00:28 EST


Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Tue, 6 Oct 2026 06:17:49 +0800 you wrote:
> The current XPCS creation logic in stmmac_pcs_setup() is problematic
> for several reasons.
>
> First, if a device tree specifies a "pcs-handle" but no select_pcs()
> callback is provided by the platform driver, the created XPCS cannot be
> used by phylink for PCS operations. The framework requires select_pcs()
> to return the PCS to the core, so the pcs-handle property becomes
> effectively useless for link management without the matching callback.
> The XPCS is still consulted by stmmac_phylink_setup() and
> stmmac_init_phy(), which makes the configuration silently half-working
> rather than clearly broken.
>
> [...]

Here is the summary with links:
- [net-next] net: stmmac: move XPCS lifetime management to platform drivers
https://git.kernel.org/netdev/net-next/c/f91afd7f7133

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html