Re: [PATCH v2 06/15] PCI: rcar-gen4: Assert resets when Gen5 PHY initialization fails

[Marek Vasut]

On 9/28/26 6:52 PM, Koichiro Den wrote:
> common_init() enables the clocks and deasserts the power and
> Application/Local resets before phy_init(). If phy_init() fails, the
> error path only disables the clocks, leaving those resets deasserted.
>
> Assert both resets before disabling the clocks to unwind the completed
> common initialization.
>
> Signed-off-by: Koichiro Den <den@xxxxxxxxxxxxx>
> ---
> Changes in v2:
>    - New patch. Place the fix(?) before the initialization refactoring.
>
> Marek, I looked through v1-v5 of your X5H series, but I'm not yet sure,
> was there a specific reason to leave resets deasserted when phy_init()
> fails? If not, this fixes the unwind before the restructuring in the
> following patches.
I agree, this change is correct, and should have a Fixes: tag .

Fixes: 3283c4db6009 ("PCI: rcar-gen4: Add support for R-Car X5H PCIe4")

Reviewed-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

Thank you for spotting this !