Re: [PATCH] pinctrl: starfive: fix missing CONFIG_OF dependencies

[Linus Walleij]

On Fri, Oct 2, 2026 at 2:47 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The common driver portion requires CONFIG_OF, but the drivers
> selecting it do not, so we get random warnings:
>
> WARNING: unmet direct dependencies detected for PINCTRL_STARFIVE_JHB100
>   Depends on [n]: PINCTRL [=y] && OF [=n]
>   Selected by [y]:
>   - PINCTRL_STARFIVE_JHB100_PER1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_PER2POK [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_SYS1 [=y] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
>   Selected by [m]:
>   - PINCTRL_STARFIVE_JHB100_PER0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
>   - PINCTRL_STARFIVE_JHB100_SYS0 [=m] && PINCTRL [=y] && (ARCH_STARFIVE || COMPILE_TEST [=y])
>
> Apparently the problem is selecting CONFIG_OF_GPIO, which is a mistake
> the newly added driver copied from others. This was recently cleaned up
> with commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies
> on OF_GPIO"). Do the same here for consistency and to avoid the warning.
>
> Fixes: 9c4d0c8fc4c1 ("pinctrl: starfive: Add StarFive JHB100 sys0 controller driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Patch applied!

Yours,
Linus Walleij