Re: [PATCH v2 2/3] mm/memory: remove the mkwrite argument from __vm_insert_mixed()

From: SJ Park

Date: Fri Oct 02 2026 - 14:45:53 EST


On Sat, 3 Oct 2026 01:05:33 +0900 Sang-Heon Jeon <ekffu200098@xxxxxxxxx> wrote:

> __vm_insert_mixed() is only called from vmf_insert_mixed() with
> mkwrite == false, so mkwrite is also always false in vm_mixed_ok()
> and insert_pfn().
>
> So remove the argument and the unreachable code in insert_pfn().
>
> No functional change.

Looks correct to me.

>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@xxxxxxxxx>

Reviewed-by: SJ Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]