Re: [PATCH v5 1/6] dt-bindings: iio: imu: icm42600: Add ICM-42670-P

[Conor Dooley]

On Fri, Oct 02, 2026 at 06:11:00PM +0100, Conor Dooley wrote:
> On Fri, Oct 02, 2026 at 01:54:25PM +0200, Kanak Shilledar wrote:
> > TDK Invensense, ICM-42670-P is a 3-axis accelerometer. The device can
> > support I2C, SPI and I3C. This device has very similar properties as
> > that of the icm42607/p. Add this device to the existing dt-binding and
> > update the description to match the devices.
> 
> Reading this it's not clear to me why a fallback cannot be used.
> 
> You say "similar properties", but what I see below is slotting into an
> existing enum, without differing restrictions.

The lack of a gyroscope is probably why? Please note that here.

pw-bot: changes-requested

> 
> Thanks,
> Conor.
> 
> > 
> > Datasheet: https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
> > Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > index 9e22b603d47fb..c79eb0a1a890e 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> > @@ -11,10 +11,10 @@ maintainers:
> >  
> >  description: |
> >    6-axis MotionTracking device that combines a 3-axis gyroscope and a 3-axis
> > -  accelerometer.
> > +  accelerometer. Some devices only have a 3-axis accelerometer.
> >  
> >    It has a configurable host interface that supports I3C, I2C and SPI serial
> > -  communication, features a 2kB FIFO and 2 programmable interrupts with
> > +  communication, features up to 2.25kB FIFO and 2 programmable interrupts with
> >    ultra-low-power wake-on-motion support to minimize system power consumption.
> >  
> >    Other industry-leading features include InvenSense on-chip APEX Motion
> > @@ -28,6 +28,7 @@ properties:
> >    compatible:
> >      oneOf:
> >        - enum:
> > +          - invensense,icm42370p
> >            - invensense,icm42600
> >            - invensense,icm42602
> >            - invensense,icm42605
> > @@ -81,6 +82,7 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > +              - invensense,icm42370p
> >                - invensense,icm42600
> >                - invensense,icm42602
> >                - invensense,icm42605
> > 
> > -- 
> > 2.43.0
> >

Attachment: signature.asc
Description: PGP signature