Re: [PATCH v4 3/8] firmware: smccc: lfa: Add timeout and trigger watchdog

[Andre Przywara]

Hi Sudeep,

On 9/21/26 17:36, Sudeep Holla wrote:
> On Fri, Sep 18, 2026 at 04:11:06PM +0200, Andre Przywara wrote:
> > From: Vedashree Vidwans <vvidwans@xxxxxxxxxx>
> >
> > Enhance PRIME/ACTIVATION functions to touch watchdog and implement
> > timeout mechanism. This update ensures that any potential hangs are
> > detected promptly and that the LFA process is allocated sufficient
> > execution time before the watchdog timer expires. These changes improve
> > overall system reliability by reducing the risk of undetected process
> > stalls and unexpected watchdog resets.
>
> I assume this change is separate from 2/8 for authorship purposes.
> Otherwise it should ideally be part of the original driver. It is prone
> to firmware bugs without these changes.

Yes, I was quite torn over this. She genuinely wrote that code, so I 
wanted to give her credit, but I see how it's odd to kind of fix up the 
original patch in the same series.
I am now leaning towards merging this patch into 2/8, and also the SMC 
access lock (7/8), since it's not really safe without them.
But then still keep Vedashree's ACPI patch (4/8) separate, as well as 
the DT patch, and the auto-activate, since they are somewhat optional.

If you have better ideas, I am all ears.

Cheers,
Andre