Re: [PATCH v2] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables

[Mark Pearson]

On Wed, Sep 30, 2026, at 8:20 AM, Mark Pearson wrote:
> On Fri, Sep 18, 2026, at 6:00 PM, Mark Pearson wrote:
>> On Fri, Sep 18, 2026, at 2:25 PM, Ilpo Järvinen wrote:
>>> On Sat, 19 Sep 2026 00:15:39 +0800, Huang Wei wrote:
>>>
>>>> The Lenovo ThinkPad X9-14 Gen 1 uses a non-standard Embedded Controller
>>>> firmware (ECFW) whose thermal and fan registers are not located at the
>>>> classic addresses. On this model the thermal registers sit at 0xA8-0xAF /
>>>> 0xB8-0xBF and the fan registers use the non-standard offsets, instead of
>>>> the legacy 0x78-0x7F / 0xC0-0xC7 (thermal) and 0x2f / 0x84 (fan).
>>>> 
>>>> Because the model is not covered by the existing quirk tables, the driver
>>>> probes the legacy thermal addresses during init, reads back 0x00 from
>>>> every register, concludes the EC is "misbehaving" and disables all
>>>> thermal sensor access:
>>>> 
>>>> [...]
>>>
>>> Thank you for your contribution, it has been applied to my local
>>> review-ilpo-next branch. Note it will show up in the public
>>> platform-drivers-x86/review-ilpo-next branch only once I've pushed my
>>> local branch there, which might take a while.
>>>
>>> FYI [if applicable to your patch], as per Linus' policy change, also
>>> fixes are mostly routed through for-next unless the fix is for a
>>> commit introduced in the most recent cycle or is clearly a regression
>>> fix.
>>>
>>> The list of commits applied:
>>> [1/1] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard 
>>> thermal/fan quirk tables
>>>       commit: bb0f3a5d6b9844b70ad696b9470762028f6d86ec
>>>
>>> --
>>>  i.
>>
>> Just a note that I have a ticket in to the FW team to confirm this 
>> (LO-4662). This platform was Linux certified so I was a bit puzzled at 
>> it being different, but I think the proposed patch is correct. Just 
>> making sure (and to figure out how we missed it...)
>>
>> I don't mean to hold up the review - just noting that this is being 
>> verified and confirmed on the Lenovo side for completeness
>>
> Confirmed that this patch is correct - the X9-14 uses the non-standard 
> implementation. Thanks for the fix - we should have caught this one :(
>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Mark

Sorry - I need to retract the above. We did a bit more checking on the specifics, as my colleague noticed some inconsistencies, and some of the offsets used are unique to this platform.

We need more time to check it and get the updated spec from the FW team, But we don't think this patch is correct I'm afraid. We're working on the correct solution.

Can I (belatedly) nack this one please.

Mark