Re: [PATCH 1/6] dt-bindings: arm: keystone: ti,sci: Update nodename pattern

[Padhi, Beleswar]

On 10/2/2026 11:57 AM, Krzysztof Kozlowski wrote:
> On Thu, Oct 01, 2026 at 01:11:26AM +0530, Beleswar Padhi wrote:
> > The $nodename pattern for TI-SCI controllers mandates specifying a unit
> > address, which in turn requires a 'reg' property. This 'reg' is only
> > used to describe an optional memory-mapped debug-messages region.
> >
> > Some controllers may not implement this debug region, so it has no 'reg'
> Which ones?


TDA54 PDM System Controller. I will add this in the commit message
in patch revision.

> > and unit address. Therefore, relax the $nodename pattern to allow the
> > unit address to be omitted for such controllers. Keep the unit address
> > mandatory for the existing ti,k2g-sci and ti,am654-sci controllers.
> >
> > Signed-off-by: Beleswar Padhi <b-padhi@xxxxxx>
> > ---
> > Note: This patch is independent can be applied directly.
> >
> > Cc: Nishanth Menon <nm@xxxxxx>
> > Cc: Tero Kristo <kristo@xxxxxxxxxx>
> > Cc: Santosh Shilimkar <ssantosh@xxxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> >
> >   .../devicetree/bindings/arm/keystone/ti,sci.yaml  | 15 ++++++++++++++-
> >   1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> > index 25a2b42105e54..67acce8a559a1 100644
> > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> > @@ -30,7 +30,7 @@ description: |
> >   
> >   properties:
> >     $nodename:
> > -    pattern: "^system-controller@[0-9a-f]+$"
> > +    pattern: "^system-controller(@[0-9a-f]+)?$"
> >   
> >     compatible:
> >       oneOf:
> > @@ -84,6 +84,19 @@ required:
> >     - mbox-names
> >     - mboxes
> >   
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - ti,k2g-sci
> > +              - ti,am654-sci
> > +    then:
> > +      properties:
> > +        $nodename:
> > +          pattern: "^system-controller@[0-9a-f]+$"
> Drop, not worth complexity.


Why? We want to make sure dt_binding_check catches system controller
nodes which have a debug region but omit the unit address.

Thanks,
Beleswar

> Best regards,
> Krzysztof