Re: [PATCH v2 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K

[Krzysztof Kozlowski]

On 01/10/2026 15:17, Griffin Kroah-Hartman wrote:
> On 9/16/26 11:06, Krzysztof Kozlowski wrote:
>> On Mon, Sep 14, 2026 at 12:25:56PM +0200, Griffin Kroah-Hartman wrote:
>>> The DW9800K's properties are too different to justify sharing the same
>>> bindings file as the dw9719, Create a separate bindings documentation
>>> for the Dongwoon Anatech DW9800K with it's updated properties.
>>>
>>> More specifically:
>>>
>>> The DW9800K did not share the SAC1 and SAC6 modes
>>> that the DW9719 used.
>>>
>>> The DW9800K does not actually have a register that matches the property
>>> description of vcm-prescale, instead the description of the clock-presc
>>> in the DW9768 is much more applicable to the functionality required
>>> according to the DW9800K datasheet.
>>
>> I don't get why it does not match. You have exactly the same first part
>> of the description, look:
>>
> There is no inherent difference between the two property names, the 
> values that the previous binding was using was completely incorrect with 
> the hardware.
> 
> The reason for this discrepancy in the first place was us guessing which 
> properties that this driver would need based on the datasheets we had 
> for older dongwoon devices.
> 
>> dw9719:
>>    Indication of VCM switching frequency dividing rate select
>>
>> Your code:
>>    Indication of VCM internal clock dividing rate select,
>>
>> Both are dividing the VCM clock rate, no?
>>
> clock-presc is used in a different dongwoon binding (dw9768) which more 
> accurately matches the function of the hardware, So we concluded that it 
> was a more appropriate name.
> either way, the values we were using with this property was completely 
> incorrect, so it had to be changed either way.
> 
> If you'd really prefer us use the older property name we can change it.
> 

So the property describes the same thing? Then use the same property
name and type. Otherwise I really do not get how two same descriptions
can be different and one "is much more applicable".

Best regards,
Krzysztof