Re: [PATCH v2 1/3] pwm: tegra: Make use of dev_err_probe()

[Uwe Kleine-König]

Hello Thierry,

On Mon, Sep 21, 2026 at 06:14:31PM +0200, Thierry Reding wrote:
> On Mon, Sep 21, 2026 at 02:46:03PM +0200, Uwe Kleine-König wrote:
> > [1] last instance was just today, where on a bananapi USB didn't work
> >     and /sys/kernel/debug/devices_deferred ended up containing:
> > 
> > 	1c13000.usb     platform: supplier 1c13400.phy not ready
> > 	1c1c000.usb     platform: supplier 1c13400.phy not ready
> > 	1c14400.usb     platform: supplier 1c13400.phy not ready
> > 	1c13400.phy     platform: supplier axp20x-usb-power-supply not ready
> > 	1c14000.usb     platform: supplier 1c13400.phy not ready
> > 	1c1c400.usb     platform: supplier 1c13400.phy not ready
> > 	axp20x-usb-power-supply
> > 
> >     It would be so easy[2] to add a useful debugging hint here
> > 
> > [2] https://lore.kernel.org/all/b699f8251afed736af454a981630926e45eb7da7.1789983244.git.ukleinek@xxxxxxxxxx/
> 
> I see. Yeah, I find it increasingly difficult to remember all the
> context of a function call, whether it is that it prints an error
> message or needs some lock to be held, sleeps or not. Sashiko has
> been really good about pointing some of those things out.

I guess a comment in the function docs would also already help me. And
an upside is that (I hope) Sashiko would understand such a comment, too.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature