Re: [PATCH v5 3/8] serial: max310x: convert RS485 delays from milliseconds to bit-times

[Tapio Reijonen]

Hi Hugo,

On Thu, 1 Oct 2026 15:11:25 -0400, Hugo Villeneuve wrote:
> > never shorter than requested, and capping at the 15 bit-times the
> > 4-bit field can hold. Centralize the HDPIXDELAY and MODE1.TRNSCVCTRL
> > programming in max310x_set_rts_ctl_params(), called from
> > set_termios() (the conversion depends on the baud rate), the
> > rs485-config worker and startup(), which each had their own copy.
>
> Could this centralization be done in a separate patch, without
> any functional changes intented, in order to facilitate the
> review of this patch?

Yes, good idea. In v6 this becomes two patches: one that only
introduces max310x_set_rts_ctl_params() and folds the three existing
copies into it, still writing the raw millisecond values (no
functional change), and this one, which then only adds the baud
caching and the millisecond-to-bit-time conversion inside the helper.

Your earlier comment on this patch is also folded in: break_ctl()
keeps the single max310x_rts_ctl(port, break_state) call at the end
instead of duplicating it in both branches.

Tapio