Re: [PATCH v2] serial: ucc_uart: Use platform IRQ helper

From: Rosen Penev

Date: Thu Oct 01 2026 - 22:05:09 EST


On Thu, Oct 1, 2026 at 1:45 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Sep 27, 2026 at 01:43:17PM -0700, Rosen Penev wrote:
> > Avoid calling irq_dispose_mapping() by letting the platform_device
> > machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> > and other errors. Handle before any allocation or anything to avoid
> > dealing with gotos.
>
> I can't really parse this, what is the bug here that you are fixing?
>
> > Assisted-by: LLM
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > ---
> > v2: move platform_get_irq() earlier.
>
> Why?
this was reported by sashiko in v1:

[Severity: High]
If platform_get_irq() returns -EPROBE_DEFER here, does this leak the
asynchronous firmware load initiated by the preceding call to
soft_uart_init()?
>
> thanks,
>
> greg k-h