Re: [PATCH v13 06/15] cxl: Make HDM reset helpers available to built-in PCI code
From: Srirangan Madhavan
Date: Thu Oct 01 2026 - 18:53:09 EST
On 9/23/26 2:40 PM, Cheatham, Benjamin wrote:
PCI can be built in while CXL_BUS is modular, so PCI reset code cannotI think you should squash this patch into 3/15. Having this earlier does two things:
depend on helpers provided by the cxl_core module.
Build the HDM resource helpers under CONFIG_CXL_RESET and restrict their
exports to cxl_core.
1) it makes it more clear why you're moving everything earlier in the set, and 2)
bisects across the pass 3 patches will all result in the same configuration.
An alternative option would be to refactor the preceding 3 patches in-place and then
move all of the helpers to this file in this patch, either would work.
I took your alternative in v14: patches 3–5 keep the helpers in hdm.c while refactoring them, and patch 6 moves them to resource.c together with the CONFIG_CXL_RESET build change. Also eliminated intermediate add/remove of resource.o from cxl_core-y.
--
Regards,
Srirangan