Re: [PATCH v13 02/15] cxl: Share CXL port upstream PCI device lookup

[Srirangan Madhavan]

On 9/23/26 6:22 PM, Jonathan Cameron wrote:
> > Factor the lookup into cxl_port_get_uport_pci_dev() and return a referenced
> > PCI device to make caller ownership explicit.
> We don't need that here, so maybe briefly state that you will do in
> new users coming shortly.
>
> > Signed-off-by: Srirangan Madhavan<smadhavan@xxxxxxxxxx>
> Assuming this is the only instance (as Ben asks) and you do
> what I suggested about not having the good path follow a goto,
> then
> Reviewed-by: Jonathan Cameron<jonathan.cameron@xxxxxxxxxxxxxxxx>
>
> > ---

read_cdat_data() was the only existing instance I found. The helper now 
has two new users in the HDM cache-update paths later in the series.

In v14 I duplicated pci_dev_put() at the early-return and error paths, 
so the successful path no longer follows a cleanup goto. I also added 
your Reviewed-by tag.

--
Regards,
Srirangan