Re: [PATCH v5 04/11] phy: qualcomm: qmp-combo: Ignore Type-C orientation for Glymur DP mode

[Nabige Aala]

On 10/1/2026 3:31 PM, Dmitry Baryshkov wrote:
> On Thu, Oct 01, 2026 at 03:04:21PM +0530, Nabige Aala wrote:
> > From: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
> >
> > Glymur platforms use a fixed DP lane mapping and do not support DP PHY
> > mode reversal based on Type-C orientation. Add a configuration flag to
> Does it handle orientation somewhere else? Where? Is it a property of
> the SoC or is it a way how it is plumbed on a particular device?

Hi Dmitry,

This is the Soc-specific property. As defined in glymur HPG DP_PHY_MODE 
should always be 0x5c

for all the case 1lane/2lane/4lane and for all the orientation 
(normal/flip).

> > ignore reverse orientation during DP mode setup and enable it for Glymur,
> > ensuring that QSERDES_DP_PHY_MODE is always programmed with the
> > fix mode value (0x5c).
> >
> > Fixes: 815891eee6687 ("phy: qcom-qmp-combo: Introduce orientation variable")
> > Signed-off-by: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Nabige Aala <nabige.aala@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 +++++++-
> >   1 file changed, 7 insertions(+), 1 deletion(-)