RE: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully initialized

[nobuhiro.iwamatsu.x90]

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: Thursday, August 20, 2026 4:05 AM
> To: Tero Kristo <kristo@xxxxxxxxxx>; Stephen Boyd <sboyd@xxxxxxxxxx>; Brian
> Masney <bmasney+clk@xxxxxxxxxx>; Jerome Brunet
> <jbrunet+clk@xxxxxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○Ｃ
> ＰＴ) <nobuhiro.iwamatsu.x90@mail.toshiba>; Nuno Sa
> <nuno.sa@xxxxxxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>; Michael
> Hennerich <Michael.Hennerich@xxxxxxxxxx>; Antoniu Miclaus
> <antoniu.miclaus@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>;
> David Lechner <dlechner@xxxxxxxxxxxx>; Andy Shevchenko
> <andy@xxxxxxxxxx>; Sunny Luo <sunny.luo@xxxxxxxxxxx>; Xianwei Zhao
> <xianwei.zhao@xxxxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Kees
> Cook <kees@xxxxxxxxxx>; Kevin Hilman <khilman@xxxxxxxxxxxx>; Mathieu
> Dubois-Briand <mathieu.dubois-briand@xxxxxxxxxxx>
> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-hwmon@xxxxxxxxxxxxxxx; linux@xxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> linux-clk@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>
> Subject: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully
> initialized
> 
> The clk_init_data structure contains several mutually-exclusive members for
> different methods to specify the possible parents of a clock, prompting drivers
> to initialize only the members they need.  However, not initializing all members
> may cause subtle issues, which are only exposed when
> CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> visconti_clk_register_gate() fills in init.parent_data, and assumes that
> init.parent_names is NULL.  However, the latter in uninitialized, and thus may
> cause a crash.
> 
> Make sure all members are fully initialized, to fix such bugs, and to avoid future
> breakage when converting drivers to a different method for specifying the
> parents.
> 
> Fixes: b4cbe606dc3674b2 ("clk: visconti: Add support common clock driver
> and reset driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro