Re: [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY

[Konrad Dybcio]

On 8/17/26 2:45 PM, George Moussalem wrote:
> On 8/17/26 16:38, Konrad Dybcio wrote:
>> On 8/17/26 2:37 PM, Konrad Dybcio wrote:
>>> On 8/13/26 12:48 PM, Krzysztof Kozlowski wrote:
>>>> On 13/08/2026 12:28, George Moussalem wrote:

[...]

>> so the implementation, matching prior art for similar cases should be:
>>
>> - phy node with #phy-cells = <1>
>> - consumer takes a reference through phys = <&phy FOO_PCIE> or FOO_USB3
>> - new driver in drivers/phy/qualcomm to coordinate the two modes
> 
> Thanks for confirming it's one device. I'm already working on a new
> version using phy-cells and having the consumer select the phy type.
> 
> However: I'm adjusting the existing phy-qcom-uniphy-pcie-28lp.c as
> that's the driver currently used for PCIe only in both IPQ5018 and IPQ5332.
> So I'm adjusting it to register 2 PHYs and provide both PCIe and USB
> functionality. Any objections/concerns?

"UNIPHY" is a bit of a loose definition, I also see that name in relation
to DSI and ethernet, but I don't have a better suggestion

Konrad