Re: [net-next v6 08/12] net: bnxt: Implement software USO

[Joe Damato]

On Mon, Mar 30, 2026 at 04:53:57PM -0700, Jakub Kicinski wrote:
> On Mon, 30 Mar 2026 09:53:33 -0700 Joe Damato wrote:
> > > > +				   bp->tx_wake_thresh);  
> > > 
> > > Is tx_wake_thresh larger than the max USO even for smallest ring size?  
> > 
> > Yes, it is.
> > 
> > Maybe its worth adding a comment in the code somewhere to make
> > this more clear? Not sure where would be an appropriate place, but maybe
> > bnxt_init_tx_rings?
> 
> Hm, as long as BNXT_MIN_TX_DESC_CNT is updated I don't think we need
> any bespoke comments 

I am hesitant to update BNXT_MIN_TX_DESC_CNT because it affects all hardware,
including devices that do USO in hardware.

It may not matter in practice since I would be bumping it from 19 to 210, but
we could just leave it as is and let fix_features and init_tx_rings deal with
ring size (as they do now).

IDK. Feels "safer" (but maybe less clear) to leave it as is. WDYT?