Re: [PATCH v9 3/6] mfd: max77759: add register bitmasks and modify irq configs for charger

[Amit Sunil Dhamne]

Hi Lee,

On 3/31/26 5:31 AM, Lee Jones wrote:
> On Wed, 25 Mar 2026, Amit Sunil Dhamne via B4 Relay wrote:
>
> > From: Amit Sunil Dhamne <amitsd@xxxxxxxxxx>
> >
> > Add register bitmasks for charger function.
> > In addition split the charger IRQs further such that each bit represents
> > an IRQ downstream of charger regmap irq chip. In addition populate the
> > ack_base to offload irq ack to the regmap irq chip framework.
> >
> > Signed-off-by: Amit Sunil Dhamne <amitsd@xxxxxxxxxx>
> > Reviewed-by: André Draszik <andre.draszik@xxxxxxxxxx>
> > ---
> >   drivers/mfd/max77759.c       |  95 ++++++++++++++++++++++---
> >   include/linux/mfd/max77759.h | 166 +++++++++++++++++++++++++++++++++++--------
> >   2 files changed, 222 insertions(+), 39 deletions(-)
> [...]
>
> > +/*
> > + * enum max77759_chgr_chgin_dtls_status - Charger Input Status
> > + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_UNDERVOLTAGE:
> > + *     Charger input voltage (Vchgin) < Under Voltage Threshold (Vuvlo)
> > + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE: Vchgin > Vuvlo and
> > + *     Vchgin < (Battery Voltage (Vbatt) + system voltage (Vsys))
> > + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_OVERVOLTAGE:
> > + *     Vchgin > Over Voltage threshold (Vovlo)
> > + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID:
> > + *     Vchgin > Vuvlo, Vchgin < Vovlo and Vchgin > (Vsys + Vbatt)
> > + */
> This comment is masquerading as a kernel-doc header, but isn't actually
> kernel-doc.  Either change the formatting or adapt the formatting to use
> /** and use W=1 to check it.
Thanks for pointing this out! I'll fix this in the next version and 
ensure it's a proper kernel-doc block.

BR,

Amit

> > +enum max77759_chgr_chgin_dtls_status {
> > +	MAX77759_CHGR_CHGIN_DTLS_VBUS_UNDERVOLTAGE,
> > +	MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE,
> > +	MAX77759_CHGR_CHGIN_DTLS_VBUS_OVERVOLTAGE,
> > +	MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID,
> > +};