Re: [PATCH v7 08/22] x86/virt/seamldr: Allocate and populate a module update request

[Dave Hansen]

On 3/31/26 05:41, Chao Gao wrote:
> +	ptr = sig;
> +	for (i = 0; i < sig_size / SZ_4K; i++) {
> +		/*
> +		 * @sig is 4KB-aligned, but that does not imply PAGE_SIZE
> +		 * alignment when PAGE_SIZE != SZ_4K. Always include the
> +		 * in-page offset.
> +		 */
> +		params->sigstruct_pa[i] = (vmalloc_to_pfn(ptr) << PAGE_SHIFT) +
> +					  ((unsigned long)ptr & ~PAGE_MASK);
> +		ptr += SZ_4K;
> +	}

There are a billion things the mainline kernel _could_ do. Like a 32-bit
4/4 split or a non-4k PAGE_SIZE on x86. But the mainline kernel doesn't
*do* this.

Why add complexity to deal with something that doesn't exist?