Re: [PATCH v2 1/2] net: phy: microchip: add downshift tunable support for LAN88xx

[Nicolai Buchwitz]

On 31.3.2026 13:29, Russell King (Oracle) wrote:
> On Tue, Mar 31, 2026 at 12:46:26AM +0200, Nicolai Buchwitz wrote:
> > Implement the standard ETHTOOL_PHY_DOWNSHIFT tunable for the LAN88xx
> > PHY. This allows runtime configuration of the auto-downshift feature
> > via ethtool:
> >
> >   ethtool --set-phy-tunable eth0 downshift on count 3
> >
> > The LAN88xx PHY supports downshifting from 1000BASE-T to 100BASE-TX
> > after 2-5 failed auto-negotiation attempts. Valid count values are
> > 2, 3, 4 and 5.
> >
> > This is based on an earlier downstream implementation by Phil Elwell.
> >
> > Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>
>
> I didn't see a cover message. Please always include a cover message 
> with
> patch series.

Apparently the cover message [1] was sent with slightly different 
recipients (although it was a single git send-email with 
--cc-cmd='scripts/get_maintainer.pl --norolestats').

> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks, I will add it to the patch.

Nicolai

> Thanks!

[1] 
https://lore.kernel.org/netdev/20260330224630.579937-1-nb@xxxxxxxxxxx/