Re: [PATCH v3 5/7] fs: handle hypothetical filesystems which use I_DONTCACHE and drop the lock in ->drop_inode

[Mateusz Guzik]

On Tue, Mar 31, 2026 at 1:23 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> On Sun, Mar 29, 2026 at 07:20:00PM +0200, Mateusz Guzik wrote:
> > diff --git a/fs/inode.c b/fs/inode.c
> > index 0050eca6d83f..a417abc64822 100644
> > --- a/fs/inode.c
> > +++ b/fs/inode.c
> > @@ -1935,20 +1935,29 @@ static void iput_final(struct inode *inode)
> >       else
> >               drop = inode_generic_drop(inode);
> >
> > -     if (!drop &&
> > -         !(inode_state_read(inode) & I_DONTCACHE) &&
> > -         (sb->s_flags & SB_ACTIVE)) {
> > +     /*
> > +      * XXXCRAP: there are ->drop_inode hooks playing nasty games releasing the
>
> Let's make that a "Note:" and remove that "XXXCRAP", please. The "nasty
> games" is plenty meta commentary.
>

"FIXME"? Given that v4 is already out, perhaps you can do the honors? :)