Re: [PATCH net-next v2 13/13] net: renesas: rswitch: add vlan aware switching
From: Nicolai Buchwitz
Date: Tue Mar 31 2026 - 04:13:58 EST
On 31.3.2026 08:10, Michael Dege wrote:
Hello,
Who can kindly help me with this?
-----Original Message-----
From: kernel test robot <lkp@xxxxxxxxx>
Sent: Sunday, March 29, 2026 10:37 PM
To: Michael Dege <michael.dege@xxxxxxxxxxx>; Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>;
Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
<edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: oe-kbuild-all@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx; Michael Dege <michael.dege@xxxxxxxxxxx>
Subject: Re: [PATCH net-next v2 13/13] net: renesas: rswitch: add vlan aware switching
Hi Michael,
kernel test robot noticed the following build errors:
[auto build test ERROR on 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681]
url: https://github.com/intel-lab-
lkp%2Flinux%2Fcommits%2FMichael-Dege%2Fnet-renesas-rswitch-improve-port-change-mode-
functions%2F20260329-
154812&data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8dd3108a%7C53d82571da1947e4
9cb4625a166a4a2a%7C0%7C0%7C639104134822998103%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIw
LjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=uP5U8NPFi2wo7VJDRGZ%2B
ubwH50bZDvNuapBP0t76lL0%3D&reserved=0
base: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
patch link:
https://lore.kernel.org/r/20260327-
rswitch_add_vlans-v2-13-
d7f4358ca57a%2540renesas.com&data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8dd31
08a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C639104134823016624%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU
1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=
2QTz%2BFk8tDeHuE2Ac5ddl8tJ2mFSrm9l9mGnnLDsdW4%3D&reserved=0
patch subject: [PATCH net-next v2 13/13] net: renesas: rswitch: add vlan aware switching
config: arm64-defconfig
(https://download.01.org/0day-
ci%2Farchive%2F20260330%2F202603300436.ryIgiB0z-
lkp%40intel.com%2Fconfig&data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8dd3108a%
7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C639104134823028947%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcG
kiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=vhwu
KaGAF4bhfSTb1VhDnII4SXsKbZ0zEPRt8ma49aM%3D&reserved=0)
compiler: aarch64-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build):
(https://download.01.org/0day-
ci%2Farchive%2F20260330%2F202603300436.ryIgiB0z-
lkp%40intel.com%2Freproduce&data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8dd310
8a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C639104134823040554%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1
hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Y
TddyGPjtxfccjUPlLwizqOqUHOuiRxPxMqoNaHWW%2Bk%3D&reserved=0)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same
patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes:
| https://lore/
| .kernel.org%2Foe-kbuild-all%2F202603300436.ryIgiB0z-lkp%40intel.com%2F
| &data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8
| dd3108a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63910413482305219
| 2%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIs
| IlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=4B
| 1hVOdPuyjze1HZCUi2v3gamNPgyeYcmx5NNzrDFjw%3D&reserved=0
All errors (new ones prefixed by >>):
aarch64-linux-ld: Unexpected GOT/PLT entries detected!
aarch64-linux-ld: Unexpected run-time procedure linkages detected!
aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.o: in function
`rswitch_port_obj_do_add_gwca':
>> drivers/net/ethernet/renesas/rswitch_l2.c:443:(.text+0x11e0): undefined reference to
`br_vlan_enabled'
aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.o: in function `rswitch_port_obj_do_add':
drivers/net/ethernet/renesas/rswitch_l2.c:412:(.text+0x135c): undefined reference to
`br_vlan_enabled'
>> aarch64-linux-ld: drivers/net/ethernet/renesas/rswitch_l2.c:423:(.text+0x13bc): undefined reference
to `br_vlan_enabled'
vim +443 drivers/net/ethernet/renesas/rswitch_l2.c
402
403 static int rswitch_port_obj_do_add(struct net_device *ndev,
404 struct switchdev_obj_port_vlan *p_vlan)
405 {
406 struct rswitch_device *rdev = netdev_priv(ndev);
407 struct rswitch_private *priv = rdev->priv;
408 struct rswitch_etha *etha = rdev->etha;
409 int err;
410
411 /* Set Rswitch VLAN mode */
412 iowrite32(br_vlan_enabled(rdev->brdev) ? FIELD_PREP(FWGC_SVM, C_TAG) : 0,
413 priv->addr + FWGC);
414
415 err = rswitch_write_vlan_table(priv, p_vlan->vid, etha->index);
416 if (err < 0)
417 return err;
418
419 /* If the default vlan for this port has been set, don't overwrite it. */
420 if (ioread32(etha->addr + EAVCC))
421 return NOTIFY_DONE;
422
> 423 if (br_vlan_enabled(rdev->brdev))
424 rswitch_modify(priv->addr, FWPC0(etha->index), 0, FWPC0_VLANSA |
FWPC0_VLANRU);
425
426 rswitch_modify(priv->addr, FWPC2(AGENT_INDEX_GWCA),
427 FIELD_PREP(FWPC2_LTWFW, BIT(etha->index)),
428 0);
429
430 return rswitch_port_set_vlan_tag(etha, p_vlan, false);
431 }
432
433 static int rswitch_port_obj_do_add_gwca(struct net_device *ndev,
434 struct rswitch_private *priv,
435 struct switchdev_obj_port_vlan *p_vlan)
436 {
437 int err;
438
439 if (!(p_vlan->flags & BRIDGE_VLAN_INFO_BRENTRY))
440 return NOTIFY_DONE;
441
442 /* Set Rswitch VLAN mode */
> 443 iowrite32(br_vlan_enabled(ndev) ? FIELD_PREP(FWGC_SVM, C_TAG) : 0, priv->addr +
FWGC);
444
445 err = rswitch_write_vlan_table(priv, p_vlan->vid, AGENT_INDEX_GWCA);
446 if (err < 0)
447 return err;
448
449 /* If the default vlan for this port has been set, don't overwrite it. */
450 if (ioread32(priv->addr + GWVCC))
451 return NOTIFY_DONE;
452
453 return rswitch_gwca_set_vlan_tag(priv, p_vlan, false);
454 }
455
The function br_vlan_enabled() is exported from br_vlan.c and the header file is if_bridge.h. Can anyone
give me a hint what might be wrong?
Looking at the other switchdev drivers, I'd suspect that `RENESAS_ETHER_SWITCH` is missing `depends on BRIDGE || BRIDGE=n`, which guards br_vlan_enabled().
Nicolai
Thank you and best regards,
Michael
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-
tests%2Fwiki&data=05%7C02%7Cmichael.dege%40renesas.com%7C27cab84d6f7640e15b4f08de8dd3108a%7C53d82571da
1947e49cb4625a166a4a2a%7C0%7C0%7C639104134823063970%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIl
YiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=wG2VKo2Ln60Ld4KV
8wHTcxRyskg0hzu0dZSVMg4v73g%3D&reserved=0