Re: [PATCH net-next] pppoe: update Kconfig URLs

[Jaco Kroon]

Hi,

On 2026/03/31 05:33, Qingfang Deng wrote:
> Both links are no longer valid. Update them to the correct URLs.
>
> Signed-off-by: Qingfang Deng <dqfext@xxxxxxxxx>
> ---
>   drivers/net/ppp/Kconfig | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
> index a1806b4b84be..c751959c53a1 100644
> --- a/drivers/net/ppp/Kconfig
> +++ b/drivers/net/ppp/Kconfig
> @@ -122,11 +122,10 @@ config PPPOE
>   	help
>   	  Support for PPP over Ethernet.
>   
> -	  This driver requires the latest version of pppd from the CVS
> -	  repository at cvs.samba.org.  Alternatively, see the
> -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
> -	  which contains instruction on how to use this driver (under
> -	  the heading "Kernel mode PPPoE").
> +	  This driver requires the latest version of pppd at
> +	  <https://ppp.samba.org>.
> +	  Alternatively, see the out-of-tree RP-PPPoE plugin at
> +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.

ppp now exclusively has the plugin code (originally from roaring penguin 
I believe).  Latest version is no longer relevant, that plugin has been 
available since at least a few versions back already (at least a decade, 
probably closer to two).

That same code has recently been dropped from rp-pppoe, which now 
primarily focusses on pppoe-server, and relies on the plugin now part of 
ppp package itself. rp-pppoe is only required if you're running a 
pppoe-server, and I don't think rp-pppoe at this stage will function 
without ppp.

Most people will never need rp-pppoe.

Kind regards,
Jaco


>   
>   choice
>   	prompt "Number of PPPoE hash bits"