Re: [PATCH v3] dt-bindings: sound: Convert pcm3060 to DT Schema

[Padmashree S S]

On Tue, Mar 31, 2026 at 12:28 AM Padmashree S S
<padmashreess2006@xxxxxxxxx> wrote:
>
>
>
> On Sat, Mar 28, 2026 at 7:20 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On Fri, Mar 27, 2026 at 05:49:18PM +0530, Padmashree S S wrote:
>> > Convert pcm3060 to DT Schema
>> >
>> > Signed-off-by: Padmashree S S <padmashreess2006@xxxxxxxxx>
>> > ---
>> >  .../devicetree/bindings/sound/pcm3060.txt     | 23 ----------
>> >  .../devicetree/bindings/sound/pcm3060.yaml    | 42 +++++++++++++++++++
>>
>> You sent it already after I asked you to slow down and implement
>> previous feedback, so this has the same issues.
>>
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>> >  2 files changed, 42 insertions(+), 23 deletions(-)
>> >  delete mode 100644 Documentation/devicetree/bindings/sound/pcm3060.txt
>> >  create mode 100644 Documentation/devicetree/bindings/sound/pcm3060.yaml
>>
>> Filename must match compatible.
>>
>> ...
>>
>> > +
>> > +  reg:
>> > +    maxItems: 1
>> > +
>> > +  ti,out-single-ended:
>> > +    type: boolean
>> > +    description: |
>>
>> Drop |
>>
>> > +      If present, the output is single-ended.
>> > +      If absent, the output is differential.
>> > +
>> > +required:
>> > +  - compatible
>> > +  - reg
>> > +
>> > +additionalProperties: false
>> > +
>> > +examples:
>> > +  - |
>> > +    i2c {
>> > +      #address-cells = <1>;
>> > +      #size-cells = <0>;
>> > +
>> > +      pcm3060: audio-codec@46 {
>>
>> Drop unused label.
>>
>> Best regards,
>> Krzysztof
>> Thanks for the review.
>> I will run checkpatch.pl, address the comments and send an updated version.