Re: [PATCH net-next v3 1/6] net: bcmgenet: convert RX path to page_pool

[Mohsin Bashir]

>   		if (priv->crc_fwd_en) {
> -			skb_trim(skb, len - ETH_FCS_LEN);
> +			skb_trim(skb, skb->len - ETH_FCS_LEN);
>   			len -= ETH_FCS_LEN;

Looks like 'len' update here is unnecessary since we are overwriting it 
later anyway?

>   		}
>   
> +		/* Set up checksum offload */
> +		if (dev->features & NETIF_F_RXCSUM) {
> +			rx_csum = (__force __be16)(status->rx_csum & 0xffff);
> +			if (rx_csum) {
> +				skb->csum = (__force __wsum)ntohs(rx_csum);
> +				skb->ip_summed = CHECKSUM_COMPLETE;
> +			}
> +		}
> +
> +		len = skb->len;