Re: [PATCH v16 01/10] PCI/AER: Introduce AER-CXL Kfifo

[Bowman, Terry]

On 3/29/2026 3:33 PM, Dan Williams wrote:
> Dan Williams wrote:
> [..]
>> I just realized that this reacquires the semaphore on every invocation,
>> and leaks stranded references.
> 
> Terry, while I think this issue is significant I think we have passed
> the point of utility of continuing to spin this series. Specifically we
> have general agreement about the approach and the issues being found at
> this point are no worse than the maintenance fixes occurring on the
> already upstream CXL infrastructure. My proposal is apply this v16 to a
> for-7.1/cxl-aer topic branch and start submitting submitting fixes on
> top of that.
> 
> If that topic is merged for v7.1, great*. If not the commit ids can be
> stablized and a for-7.2/cxl-aer topic branch can start up from something
> like:
> 
>     git checkout -b for-7.2/cxl-aer v7.1-rc1 && git merge for-7.1/cxl-aer
> 
> * The primary merge blocker question for me is whether PCI core agrees
> to the proposal that CXL AER requires 'struct cxl_port' objects and
> forwarding notifications from the built-in PCI AER driver to the modular
> CXL core.

Ok, I'll align with the new approach to work with the changes on the 
feature branch. I'll begin with the fixes for the ref counting and adding 
your recommended semaphore change.

- Terry