Re: [PATCH 2/7] cache: andes_llcache: refactor initialization and cache operations
From: Conor Dooley
Date: Mon Mar 30 2026 - 11:29:54 EST
On Mon, Mar 30, 2026 at 03:02:11PM +0200, Krzysztof Kozlowski wrote:
> On 30/03/2026 12:27, Hui Min Mina Chou wrote:
> > This patch cleans up the Andes LLC cache driver:
> > - improved error handling in andes_cache_init() by using goto labels
> > - updated andes_dma_cache_inv/wback() to check for !size instead of
> > start == end
> > - cache-line-size mismatch from an error to a warning
> > - Use ALIGN and ALIGN_DOWN helpers instead of the alignment logic in
> > andes_dma_cache_inv() and andes_dma_cache_wback().
>
> Please read submitting patches document. One thing per commit with
> proper rationale WHY you are doing this.
Applies to multiple patches too. Anything here with a bullet list needs
to be several patches.
Attachment:
signature.asc
Description: PGP signature