Re: [PATCH v2 3/3] arm64: dts: qcom: kaanpaali: Add USB support for QRD platform

[Dmitry Baryshkov]

On Sun, Mar 29, 2026 at 11:45:48PM +0530, Krishna Kurapati wrote:
> 
> 
> On 3/29/2026 11:37 PM, Dmitry Baryshkov wrote:
> > On Sun, Mar 29, 2026 at 11:22:49PM +0530, Krishna Kurapati wrote:
> > > From: Ronak Raheja <ronak.raheja@xxxxxxxxxxxxxxxx>
> > > 
> > > Enable USB support on Kaanapali QRD variant. Enable USB controller in
> > > device mode till glink node is added.
> > 
> > Why can't it be added as a part of this patchset?
> > 
> 
> Hi Dmitry,
> 
>  SoCCP changes are not yet acked. Hence I wanted to get the base changes in.

=> commit message or cover letter, please.

> 
> Regards,
> Krishna,
> 
> > > 
> > > Signed-off-by: Ronak Raheja <ronak.raheja@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 27 ++++++++++++++++++++++
> > >   1 file changed, 27 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> > > index 6a7eb7f4050a..1929ea273a4f 100644
> > > --- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> > > +++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> > > @@ -80,6 +80,11 @@ key-volume-up {
> > >   			wakeup-source;
> > >   		};
> > >   	};
> > > +
> > > +	pmih0108_e1_eusb2_repeater {
> > > +		vdd18-supply = <&vreg_l15b_1p8>;
> > > +		vdd3-supply = <&vreg_l5b_3p1>;
> > > +	};
> > >   };
> > >   &apps_rsc {
> > > @@ -821,3 +826,25 @@ &ufs_mem_phy {
> > >   	status = "okay";
> > >   };
> > > +
> > > +&usb {
> > > +	dr_mode = "peripheral";
> > > +
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usb_hsphy {
> > > +	vdd-supply = <&vreg_l4f_0p8>;
> > > +	vdda12-supply = <&vreg_l1d_1p2>;
> > > +
> > > +	phys = <&pmih0108_e1_eusb2_repeater>;
> > > +
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usb_dp_qmpphy {
> > > +	vdda-phy-supply = <&vreg_l1d_1p2>;
> > > +	vdda-pll-supply = <&vreg_l4f_0p8>;
> > > +
> > > +	status = "okay";
> > > +};
> > > -- 
> > > 2.34.1
> > > 
> > 
> 

-- 
With best wishes
Dmitry