Re: [PATCH] staging: greybus: audio_manager: Add missing newline to sysfs_emit outputs

[Dan Carpenter]

On Sat, Mar 28, 2026 at 10:15:27AM +0530, Shivam Gupta wrote:
> sysfs_emit outputs in audio_manager_module.c do not include a terminating
> newline, which is required for proper sysfs formatting.
> 
> Add newline characters to all sysfs_emit format strings.
> 
> Signed-off-by: Shivam Gupta <shivgupta751157@xxxxxxxxx>
> ---

"Proper sysfs format" is all well and good, but this is something which
already exists and adding a newline is changing the API.  If you were a
maintainer of this code, then I would have more confidence that you know
all the user space code which uses this API and are able to test it
thouroughly.

We merged a similar change recently and, whatever, that's fine, probably
it doesn't break anything.  But the more we do it, the more likely we
are to break something so my instinct is that we should discourage this
kind of change.

regards,
dan carpenter