Re: [PATCH v4 2/5] arm64: dts: sophgo: add initial Milk-V Duo S board support

[Michael Opdenacker]

Hi Joshua

Thanks a lot for this new update!

On 3/28/26 6:34 PM, Joshua Milas wrote:
> Adds initial arm64 support for the Milk-V Duo S board
> [1] making it possible to boot Linux to the command line.
>
> Link: https://milkv.io/duo-s [1]
>
> Signed-off-by: Joshua Milas <josh.milas@xxxxxxxxx>
...
> diff --git a/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
> new file mode 100644
> index 0000000000000..4ae44b40f9edb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/sophgo/sg2000-milkv-duo-s.dts
...
> +
> +&usb {
> +       dr_mode = "host";
> +       status = "okay";
> +};


You have a small checkpatch.pl issue here:

./scripts/checkpatch.pl *.patch
...
WARNING: please, no spaces at the start of a line
#120: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:82:
+       dr_mode = "host";$

WARNING: please, no spaces at the start of a line
#121: FILE: arch/riscv/boot/dts/sophgo/sg2000-milkv-duo-s.dts:83:
+       status = "okay";$

Replace the spaces by a tab as in the other entries in the DTS and you 
should be fine.
Thanks again
Cheers
Michael.

--
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com