Re: [PATCH] arm64: dts: qcom: msm8996: add blsp2_spi4 node

[Christopher Obbard]

Hi Dmitry,

Thanks for the review.

On Sun, 29 Mar 2026 at 17:03, Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Mar 29, 2026 at 02:19:15PM +0100, Christopher Obbard wrote:
> > Add the BLSP2 SPI4 controller node together with its default and sleep
> > pinctrl states.
> >
> > Signed-off-by: Christopher Obbard <christopher.obbard@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8996.dtsi | 41 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >
> > @@ -3417,6 +3441,23 @@ blsp2_i2c3: i2c@75b7000 {
> >                       status = "disabled";
> >               };
> >
> > +             blsp2_spi4: spi@75b9000 {
>
> This should be coming after i2c@75b9000 (which needs to be renamed to
> i2c4, btw)

I will move the node in the next revision.
I will also add a separate commit to rename i2c@75b9000 from
blsp2_i2c5 to blsp2_i2c4. I assume the pinctrls also need to be
renamed to i2c4?
Also, do you know of any other nodes which need to be renamed while I am there?


> > +                     compatible = "qcom,spi-qup-v2.2.1";
> > +                     reg = <0x075b9000 0x600>,
> > +                             <0x07584000 0x2b000>;
>
> This wasn't tested against the bindings.

Oops - I will solve this in the next revision.


Cheers!

Chris