Re: [PATCH v4 3/9] media: iris: retrieve UBWC platform configuration

[Dmitry Baryshkov]

On Thu, Mar 26, 2026 at 10:36:05AM +0530, Dikshita Agarwal wrote:
> 
> 
> On 1/25/2026 5:00 PM, Dmitry Baryshkov wrote:
> > Specifying UBWC data in each driver doesn't scale and is prone to
> > errors. Request UBWC data from the central database in preparation to
> > using it through the rest of the driver.
> > 
> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>
> > Tested-by: Wangao Wang <wangao.wang@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/qcom/iris/Kconfig      | 1 +
> >  drivers/media/platform/qcom/iris/iris_core.h  | 4 ++++
> >  drivers/media/platform/qcom/iris/iris_probe.c | 5 +++++
> >  3 files changed, 10 insertions(+)
> > 
> > @@ -244,6 +245,10 @@ static int iris_probe(struct platform_device *pdev)
> >  
> >  	core->iris_platform_data = of_device_get_match_data(core->dev);
> >  
> > +	core->ubwc_cfg = qcom_ubwc_config_get_data();
> > +	if (IS_ERR(core->ubwc_cfg))
> > +		return PTR_ERR(core->ubwc_cfg);
> 
> Afterthought: This change assumes that the presence of a UBWC config
> implies Iris UBWC support. However, some platforms (e.g. qcm2290) do have
> UBWC data defined at the SoC level but do not support UBWC in the video
> firmware, which could potentially surface during SYS_INIT if UBWC is
> advertised unconditionally, so this might be worth double‑checking.

No, this change implies that the lack of the UBWC config is an error for
modern platforms (which it is anyway).

-- 
With best wishes
Dmitry