[PATCH v5 2/4] platform/x86: int3472: Rename pled to led in LED registration code

From: Marco Nenciarini

Date: Fri Mar 27 2026 - 14:14:30 EST


Rename the privacy LED functions, struct type and member from
pled/int3472_pled/register_pled to led/int3472_led/register_led to
prepare for supporting additional LED types (e.g. strobe/IR flood).

No functional change.

Signed-off-by: Marco Nenciarini <mnencia@xxxxxxxx>
---
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
drivers/platform/x86/intel/int3472/discrete.c | 4 +-
drivers/platform/x86/intel/int3472/led.c | 48 +++++++++----------
include/linux/platform_data/x86/int3472.h | 8 ++--
3 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index 1505fc3..cb24763 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -348,7 +348,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,

break;
case INT3472_GPIO_TYPE_PRIVACY_LED:
- ret = skl_int3472_register_pled(int3472, gpio);
+ ret = skl_int3472_register_led(int3472, gpio);
if (ret)
err_msg = "Failed to register LED\n";

@@ -422,7 +422,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_device *int3472)
gpiod_remove_lookup_table(&int3472->gpios);

skl_int3472_unregister_clock(int3472);
- skl_int3472_unregister_pled(int3472);
+ skl_int3472_unregister_led(int3472);
skl_int3472_unregister_regulator(int3472);
}
EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE");
diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c
index 4c52f99..8e92e8e 100644
--- a/drivers/platform/x86/intel/int3472/led.c
+++ b/drivers/platform/x86/intel/int3472/led.c
@@ -6,57 +6,57 @@
#include <linux/leds.h>
#include <linux/platform_data/x86/int3472.h>

-static int int3472_pled_set(struct led_classdev *led_cdev,
- enum led_brightness brightness)
+static int int3472_led_set(struct led_classdev *led_cdev,
+ enum led_brightness brightness)
{
- struct int3472_pled *pled = container_of(led_cdev, struct int3472_pled, classdev);
+ struct int3472_led *led = container_of(led_cdev, struct int3472_led, classdev);

- gpiod_set_value_cansleep(pled->gpio, brightness);
+ gpiod_set_value_cansleep(led->gpio, brightness);
return 0;
}

-int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)
+int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)
{
- struct int3472_pled *pled = &int3472->pled;
+ struct int3472_led *led = &int3472->led;
char *p;
int ret;

- if (pled->classdev.dev)
+ if (led->classdev.dev)
return -EBUSY;

- pled->gpio = gpio;
+ led->gpio = gpio;

/* Generate the name, replacing the ':' in the ACPI devname with '_' */
- snprintf(pled->name, sizeof(pled->name),
+ snprintf(led->name, sizeof(led->name),
"%s::privacy_led", acpi_dev_name(int3472->sensor));
- p = strchr(pled->name, ':');
+ p = strchr(led->name, ':');
if (p)
*p = '_';

- pled->classdev.name = pled->name;
- pled->classdev.max_brightness = 1;
- pled->classdev.brightness_set_blocking = int3472_pled_set;
+ led->classdev.name = led->name;
+ led->classdev.max_brightness = 1;
+ led->classdev.brightness_set_blocking = int3472_led_set;

- ret = led_classdev_register(int3472->dev, &pled->classdev);
+ ret = led_classdev_register(int3472->dev, &led->classdev);
if (ret)
return ret;

- pled->lookup.provider = pled->name;
- pled->lookup.dev_id = int3472->sensor_name;
- pled->lookup.con_id = "privacy";
- led_add_lookup(&pled->lookup);
+ led->lookup.provider = led->name;
+ led->lookup.dev_id = int3472->sensor_name;
+ led->lookup.con_id = "privacy";
+ led_add_lookup(&led->lookup);

return 0;
}

-void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)
+void skl_int3472_unregister_led(struct int3472_discrete_device *int3472)
{
- struct int3472_pled *pled = &int3472->pled;
+ struct int3472_led *led = &int3472->led;

- if (IS_ERR_OR_NULL(pled->classdev.dev))
+ if (IS_ERR_OR_NULL(led->classdev.dev))
return;

- led_remove_lookup(&pled->lookup);
- led_classdev_unregister(&pled->classdev);
- gpiod_put(pled->gpio);
+ led_remove_lookup(&led->lookup);
+ led_classdev_unregister(&led->classdev);
+ gpiod_put(led->gpio);
}
diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
index b1b8375..7af6731 100644
--- a/include/linux/platform_data/x86/int3472.h
+++ b/include/linux/platform_data/x86/int3472.h
@@ -121,12 +121,12 @@ struct int3472_discrete_device {
u8 imgclk_index;
} clock;

- struct int3472_pled {
+ struct int3472_led {
struct led_classdev classdev;
struct led_lookup_data lookup;
char name[INT3472_LED_MAX_NAME_LEN];
struct gpio_desc *gpio;
- } pled;
+ } led;

struct int3472_discrete_quirks quirks;

@@ -160,7 +160,7 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
const char *second_sensor);
void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3472);

-int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);
-void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472);
+int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);
+void skl_int3472_unregister_led(struct int3472_discrete_device *int3472);

#endif
--
2.47.3