Re: [PATCH v1 1/2] platform/x86/intel-uncore-freq: Rename instance_id

[Artem Bityutskiy]

On Fri, 2026-03-27 at 15:36 +0000, Maciej Wieczor-Retman wrote:
>   * @die_id:		Die id for this instance
>   * @domain_id:		Power domain id for this instance
>   * @cluster_id:		cluster id in a domain
> - * @instance_id:	Unique instance id to append to directory name
> + * @seqname_id:		Unique id to append to directory name
>   * @name:		Sysfs entry name for this instance
>   * @agent_type_mask:	Bit mask of all hardware agents for this domain
>   * @uncore_attr_group:	Attribute group storage
> @@ -71,7 +71,7 @@ struct uncore_data {
>  	int die_id;
>  	int domain_id;
>  	int cluster_id;
> -	int instance_id;
> +	int seqname_id;
>  	char name[32];
>  	u16  agent_type_mask;

Nitpick: "seqname_id" reads like "sequence name ID" rather than a
sequence number. Consider "seqnum" or "sequence_id" for better clarity.
Just a suggestion based on how the name comes across, but not big deal.

Artem.