Re: [PATCH 1/4] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection

From: K Prateek Nayak

Date: Fri Mar 27 2026 - 07:01:20 EST


Hello Andrea,

On 3/26/2026 8:32 PM, Andrea Righi wrote:
> /* This CPU fits with all requirements */
> - if (fits > 0)
> - return cpu;
> + if (fits > 0) {
> + if (prefer_idle_cores && on_idle_core)
> + return cpu;
> + if (!prefer_idle_cores)
> + return cpu;

nit.

Can the above two be re-wittern as:

if (!prefer_idle_cores || on_idle_core)
return cpu;

since they are equivalent.

--
Thanks and Regards,
Prateek