Re: [PATCH v2 1/4] ASoC: SDCA: make q78_get_volsw and q78_put_volsw extern

[Charles Keepax]

On Thu, Mar 26, 2026 at 11:47:09PM +0530, Niranjan H Y wrote:
>  q78_get_volsw and q78_put_volsw are get and set functions
> in sdca library to handle 16bit signed Q7.8 values for
> Volume control. Make them extern so that ASoC drivers can
> reuse them.
> 
> Signed-off-by: Niranjan H Y <niranjan.hy@xxxxxx>
> ---
> @@ -57,5 +59,9 @@ int sdca_asoc_hw_params(struct device *dev, struct regmap *regmap,
>  			struct snd_pcm_substream *substream,
>  			struct snd_pcm_hw_params *params,
>  			struct snd_soc_dai *dai);
> +int q78_put_volsw(struct snd_kcontrol *kcontrol,
> +		  struct snd_ctl_elem_value *ucontrol);
> +int q78_get_volsw(struct snd_kcontrol *kcontrol,
> +		  struct snd_ctl_elem_value *ucontrol);

Lets rename these to sdca_asoc_q78_put_volsw and
sdca_asoc_q78_get_volsw to be more consistent with the other
exported functions. Otherwise this looks good to me.

Thanks,
Charles