Re: [PATCH v5] staging: media: atomisp: pci Move GP_TIMER_BASE to where it is used

[Andy Shevchenko]

On Fri, Mar 27, 2026 at 01:54:58AM +0530, Anushka Badhe wrote:
> GP_TIMER_BASE is only used in gp_timer.c, so there is no need to
> define it in system_local.c and declare it as extern in system_local.h.
> 
> Move the definition directly into gp_timer.c and remove the extern
> declaration from system_local.h, along with its mention in gp_timer.h.

...

> Note:
> * This patch is part of the GSoC2026 application process for device tree
> bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

Not sure how it's related, but thanks for cleaning this driver up!

...

> +/*GP TIMER , all timer registers are inter-twined,
> + * so, having multiple base addresses for
> + * different timers does not help
> + */

Now you also may fix the multi-line comment style and amend the text.

/*
 * All timer registers are inter-twined, so having multiple base addresses
 * for different timers does not help.
 */

With that being fixed, you may add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko