Re: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c

[Andy Shevchenko]

On Fri, Mar 27, 2026 at 08:41:06AM +0530, Anushka Badhe wrote:
> GP_TIMER_BASE is only used in gp_timer.c and it does not need to be
> globally visible.
> 
> Move its declaration from system_local.c to gp_timer.c and make it file
> local by marking it static. Remove external declaration from system_local.h
> and its usage in gp_timer.h
> 
> This fixes a sparse warning about global visibility and cleans up
> unnecessary global exposure.

...

> ---
> Changes in v6:
> - Mark scope of GP_TIMER_BASE static

Good catch, but read my comment against v5. And slow down with new versions,
no new version within 24h, please!

-- 
With Best Regards,
Andy Shevchenko