Re: [PATCH] staging: rtl8723bs: remove spaces before tabs in hal_com.c

[Dan Carpenter]

On Thu, Mar 26, 2026 at 01:13:25PM -0500, Ethan Tidmore wrote:
> On Wed Mar 25, 2026 at 6:55 PM CDT, MrXploisLite wrote:
> > Fix checkpatch warning 'please, no space before tabs' in comment blocks.
> > This change removes spaces that precede tab characters in three comment
> > lines within the _TwoOutPipeMapping and _ThreeOutPipeMapping functions.
> >
> > No functional change, only whitespace cleanup to comply with kernel
> > coding style.
> >
> > Signed-off-by: MrXploisLite <arokigaming@xxxxxxxxx>
> > ---
> 
> I believe this has been NACKed in the past. This is just changing
> whitespace in a comment, it doesn't really "improve" anything.
> 

Huh.  I can't believe you remember conversations from 2 months ago.  I
had to look it up.  I did NAK this patch, but the reason for that is
the the alignment is wrong before and after the patch.  It should be
something like:

		/*   BK,   BE,   VI,   VO,  BCN,  CMD,  MGT, HIGH, HCCA */
		/*    0,    1,    0,    1,    0,    0,    0,    0,    0 */
		/* 0:ep_0 num, 1:ep_1 num */

So the HCCA column header is over the last zero.

Although, looking at it now, we could just delete the comment.  I think
it was copy and pasted in during development so the author didn't have to
switch windows back and forth when they were implementing the code.  I
don't think it was supposed to be in the released code since it doesn't
add any new information.

pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
The 1 here matches the VO column.                 ^     ^^

Check that everything is implemented correctly and then just delete
these comments.

regards,
dan carpenter