Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI
From: Krzysztof Kozlowski
Date: Fri Mar 27 2026 - 02:53:29 EST
On 26/03/2026 17:55, Sibi Sankar wrote:
>
> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote:
>> On 26/03/2026 15:21, Gopikrishna Garmidi wrote:
>>> The display, peripherals (touchpad/touchscreen/keypad), usb and their
>>> dependent device nodes are common to both Glymur and Mahua CRDs,
>>> so move them from glymur-crd.dts to glymur-crd.dtsi to enable code
>>> reuse.
>>>
>> Same questions as for earlier tries (why this has to be repeated?), e.g.
>> x1-crd: Please describe here what is the actual common hardware. In
>> terms of physical hardware, not what you want to share.
>
>
> There seems to be some kind of confusion here. This patch doesn't
Indeed!
> introduce the common board file rather it just moves the nodes
> mentioned in the commit message to the common board file.
>
> https://lore.kernel.org/lkml/20260318124100.212992-3-gopikrishna.garmidi@xxxxxxxxxxxxxxxx/
The question stays. The common DTSI represented actual shared
motherboard design between these, so I would like to still see the
answers here. I just don't trust such commits because they mimic
downstream approach (and they were actually copying downstream in the past).
Best regards,
Krzysztof