Re: [PATCH net v2] net: qrtr: fix endian handling of confirm_rx field

[Manivannan Sadhasivam]

On Thu, Mar 26, 2026 at 07:45:07AM +0100, Alexander Wilhelm wrote:
> On Wed, Mar 25, 2026 at 06:07:37PM +0000, Simon Horman wrote:
> > On Tue, Mar 24, 2026 at 01:28:32PM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Mar 24, 2026 at 08:50:33AM +0100, Alexander Wilhelm wrote:
> > > > Convert confirm_rx to little endian when enqueueing and convert it back on
> > > > receive. This fixes control flow on big endian hosts, little endian is
> > > > unaffected.
> > > > 
> > > > On transmit, store confirm_rx as __le32 using cpu_to_le32(). On receive,
> > > > apply le32_to_cpu() before using the value. !! ensures the value is 0 or 1
> > > > in native endianness, so the conversion isn’t strictly required here, but
> > > > it is kept for consistency and clarity.
> > > > 
> > > > Fixes: 5fdeb0d372ab ("net: qrtr: Implement outgoing flow control")
> > > > Signed-off-by: Alexander Wilhelm <alexander.wilhelm@xxxxxxxxxxxx>
> > > 
> > > Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> > 
> > Sorry if this contradicts my review of v1.
> > 
> > But as this isn't strictly necessary let's target net-next
> > and drop the Fixes tag.
> 
> Sure, I will rebase onto the latest `net-next` repository and send out `v3`,
> without a "Fixes" tag.
> 

FWIW: Adding Fixes tag doesn't mean that the patch should be queued for -rcS.

- Mani

-- 
மணிவண்ணன் சதாசிவம்